Skip to content

branch-4.1: [fix](parse) No longer throws exceptions when parse datetime failed in from_olap_string #63035#63073

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-63035-branch-4.1
May 9, 2026
Merged

branch-4.1: [fix](parse) No longer throws exceptions when parse datetime failed in from_olap_string #63035#63073
yiguolei merged 1 commit into
branch-4.1from
auto-pick-63035-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 8, 2026

Cherry-picked from #63035

…n `from_olap_string` (#63035)

Problem Summary: SerDe from_olap_string, from_fe_string, and
from_zonemap_string handled invalid scalar strings inconsistently: some
supported types returned errors while others filled default fields. This
change makes supported string deserialization paths fill type defaults
consistently on parse failure.

ATTN: We used to write some values in zonemap that were considered
unreasonable after upgrading to later versions, as these values were
actually not used (mostly just placeholders in partial updates or
something). The only reasonable approach was to ignore them.
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 8, 2026 07:31
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
Copy link
Copy Markdown
Contributor

yiguolei commented May 9, 2026

skip buildall

@yiguolei yiguolei merged commit 117f160 into branch-4.1 May 9, 2026
32 of 34 checks passed
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented May 9, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels May 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented May 9, 2026

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants